Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Bump Azure.Identity from 1.9.0 to 1.10.2 in /src/Bicep.Core" #12196

Conversation

anthony-c-martin
Copy link
Member

@anthony-c-martin anthony-c-martin commented Oct 18, 2023

Reverts #12195

The original PR has a bug which breaks live validation (Azure/azure-sdk-for-net#39377), however the live validation checks don't block merging. We'll need to revert until we understand the issue better.

Microsoft Reviewers: Open in CodeFlow

@github-actions
Copy link
Contributor

github-actions bot commented Oct 18, 2023

Test this change out locally with the following install scripts (Action run 6568565673)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 6568565673
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 6568565673"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 6568565673
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 6568565673"

@github-actions
Copy link
Contributor

Test Results

     132 files  ±0       132 suites  ±0   3h 50m 20s ⏱️ - 15m 40s
10 673 tests ±0  10 673 ✔️ ±0  0 💤 ±0  0 ±0 
51 579 runs  ±0  51 579 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 16ff918. ± Comparison against base commit 644aaf0.

Copy link
Member

@majastrz majastrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@majastrz majastrz merged commit 865577d into main Oct 19, 2023
47 checks passed
@majastrz majastrz deleted the revert-12195-dependabot/nuget/src/Bicep.Core/Azure.Identity-1.10.2 branch October 19, 2023 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants