Load documentationUri from Bicep registry module index data

[shenglol]

The AVM module paths use a different convention than other public registry modules, so we cannot rely on a fixed module path format to generate documentUri for modules when creating completions for public registry module paths and versions. Now that documentUri is added to the public registry module index data, we should use it directly.

The PR also fixes a bad HttpClient usage pattern (using var httpClient = new HttpClient()) that can lead to exhaustion of available TCP ports by leveraging Typed Clients with IHttpClientFactory .

Closes #12122.

Microsoft Reviewers: Open in CodeFlow

[github-actions]

Test this change out locally with the following install scripts (Action run 6671150695)

VSCode

• Mac/Linux

  bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 6671150695

• Windows

  iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 6671150695"

Azure CLI

• Mac/Linux

  bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 6671150695

• Windows

  iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 6671150695"

[github-actions]

Test Results

     132 files  ±  0       132 suites  ±0   4h 27m 2s ⏱️ + 20m 2s
10 670 tests  -   3  10 670 ✔️  -   3  0 💤 ±0  0 ❌ ±0 
51 567 runs   - 12  51 567 ✔️  - 12  0 💤 ±0  0 ❌ ±0 

Results for commit 63240e1. ± Comparison against base commit 4137ecc.

♻️ This comment has been updated with latest results.

[StephenWeatherford]

I don't want you to bother changing this back, but why add all the whitespace? This style doesn't improve readability, while grouping by similarity IMHO does.

[shenglol]

It's a convention that I'm used to (not sure where I learned it from, maybe ReSharper or StyleCop), and I find it slightly more readable with line breaks between fields. I'm have no objections to removing the line breaks, but personally I'm not a fan of grouping fields by similarity, and I'd follow https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1201.md for sorting class members.