Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch experimental deploy pane from opt-in to opt-out model #12215

Merged
merged 2 commits into from Oct 27, 2023
Merged

Switch experimental deploy pane from opt-in to opt-out model #12215

merged 2 commits into from Oct 27, 2023

Conversation

anthony-c-martin
Copy link
Member

@anthony-c-martin anthony-c-martin commented Oct 21, 2023 •
edited

  • Invert deploy pane setting from opt-in to opt-out
  • Add experimental warning banner
  • Add basic e2e test
Microsoft Reviewers: Open in CodeFlow

@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2023 •
edited

Test this change out locally with the following install scripts (Action run 6672558907)

VSCode
  • Mac/Linux 
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 6672558907
  • Windows 
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 6672558907"
Azure CLI
  • Mac/Linux 
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 6672558907
  • Windows 
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 6672558907"

@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2023 •
edited

Test Results

     132 files  ±0       132 suites  ±0   4h 28m 38s ⏱️ - 40m 28s
10 682 tests ±0  10 682 ✔️ +2  0 💤 ±0  0 ❌  - 2 
51 623 runs  ±0  51 623 ✔️ +2  0 💤 ±0  0 ❌  - 2 

Results for commit ef14c14. ± Comparison against base commit c06a72a.

♻️ This comment has been updated with latest results.

@anthony-c-martin anthony-c-martin changed the title Remove experimental setting for deploy pane Switch experimental deploy pane from opt-in to opt-out model Oct 27, 2023
shenglol
shenglol approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@shenglol shenglol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@anthony-c-martin anthony-c-martin enabled auto-merge (squash) October 27, 2023 21:15
@anthony-c-martin anthony-c-martin merged commit 8d5c061 into main Oct 27, 2023
46 checks passed
@anthony-c-martin anthony-c-martin deleted the ant/pane branch October 27, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shenglol shenglol shenglol approved these changes

@StephenWeatherford StephenWeatherford Awaiting requested review from StephenWeatherford

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anthony-c-martin @shenglol