Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dynamic loading feature to load providers from custom bicepconfig.json aliases #12267

Merged
merged 61 commits into from Nov 14, 2023

Conversation

asilverman
Copy link
Contributor

@asilverman asilverman commented Oct 24, 2023

Overview

  • Adds new tests to exercise loading dynamically from custom bicepconfig.json aliases
  • Extracts the test setup for mocking provider manifests to a shared initialization logic increasing readability
  • Renames several classes that are not module specific to use the keyword 'artifact' in their name
  • Adds a ResourceTypeProviderFactory class that caches providers improving the compilation speed
  • Refactors NamespaceType? TryGetNamespace() to use a provider descriptor object reducing the number of arguments passed to it and improving readability and separation of concerns.
  • Introduces the use of builtin version to distinguish between statically loaded az from dynamically loaded ones

Fixes

Microsoft Reviewers: Open in CodeFlow

@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2023

Test this change out locally with the following install scripts (Action run 6869198300)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 6869198300
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 6869198300"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 6869198300
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 6869198300"

@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2023

Test Results

     132 files  ±    0       132 suites  ±0   4h 5m 56s ⏱️ - 48m 49s
10 859 tests +176  10 859 ✔️ +177  0 💤 ±0  0  - 1 
52 359 runs  +732  52 359 ✔️ +733  0 💤 ±0  0  - 1 

Results for commit 24f610b. ± Comparison against base commit 6db2502.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@shenglol shenglol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@asilverman asilverman enabled auto-merge (squash) November 14, 2023 19:50
@asilverman asilverman merged commit 603059c into main Nov 14, 2023
47 checks passed
@asilverman asilverman deleted the asilverman/refactor/TryGetNamespace branch November 14, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
story: dynamic type loading Collects all work items related to decoupling of Bicep types from compiler
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants