Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centralize imported symbol to ARM expression conversion #12405

Merged
merged 2 commits into from Nov 13, 2023
Merged

Conversation

jeskew
Copy link
Contributor

@jeskew jeskew commented Nov 8, 2023

Resolves #12396

This PR updates the TemplateWriter and ExpressionConverter to handle imported symbols as they're being compiled to ARM expressions. Previously, imported symbols were replaced with an ExpressionRewriteVisitor at earlier stages of processing, but there are some top-level resource properties that are not captured in the IR and thus wouldn't get replaced.

Microsoft Reviewers: Open in CodeFlow

… rather than trying to replace them in earlier processing stages
Copy link
Contributor

github-actions bot commented Nov 8, 2023

Test this change out locally with the following install scripts (Action run 6850503183)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 6850503183
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 6850503183"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 6850503183
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 6850503183"

Copy link
Contributor

github-actions bot commented Nov 8, 2023

Test Results

     132 files  ±0       132 suites  ±0   4h 43m 39s ⏱️ - 25m 45s
10 692 tests +1  10 692 ✔️ +1  0 💤 ±0  0 ±0 
51 663 runs  +4  51 663 ✔️ +4  0 💤 ±0  0 ±0 

Results for commit d85934a. ± Comparison against base commit 7079cea.

♻️ This comment has been updated with latest results.

@jeskew jeskew changed the title Centralize imported symbol -> ARM expression conversion Centralize imported symbol to ARM expression conversion Nov 8, 2023
@jeskew jeskew marked this pull request as ready for review November 8, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants