Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UseResourceIdFunctionsRule to account for nullable and aggregate types #12421

Merged
merged 2 commits into from Nov 13, 2023

Conversation

jeskew
Copy link
Contributor

@jeskew jeskew commented Nov 10, 2023

Resolves #12419

The UseResourceIdFunctionsRule linter rule doesn't report any diagnostics if a parameter is supplied for a resource property that expects a resource ID, but this exemption doesn't apply directly to parameter properties. This didn't raise any issues in the past because prior to the introduction of user-defined types, parameter properties would always have an any type, and the linter rule will only raise diagnostics on string-typed values.

Microsoft Reviewers: Open in CodeFlow

@jeskew jeskew requested a review from a team November 10, 2023 15:28
Copy link
Contributor

github-actions bot commented Nov 10, 2023

Test this change out locally with the following install scripts (Action run 6849997164)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 6849997164
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 6849997164"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 6849997164
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 6849997164"

Copy link
Contributor

github-actions bot commented Nov 10, 2023

Test Results

     132 files  ±  0       132 suites  ±0   4h 47m 8s ⏱️ - 14m 15s
10 690 tests +  4  10 690 ✔️ +  4  0 💤 ±0  0 ±0 
51 655 runs  +16  51 655 ✔️ +16  0 💤 ±0  0 ±0 

Results for commit 34da0ae. ± Comparison against base commit 8171b4c.

♻️ This comment has been updated with latest results.

@jeskew jeskew merged commit 7079cea into main Nov 13, 2023
47 checks passed
@jeskew jeskew deleted the jeskew/12419 branch November 13, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive for 'use-resource-id-functions' linter rule when a user-defined data type is used
2 participants