misc updates to readme, added PR template, added small ci/cd doc #1245
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1245 +/- ##
=======================================
Coverage 94.48% 94.48%
=======================================
Files 338 338
Lines 16987 16987
Branches 14 14
=======================================
Hits 16050 16050
Misses 937 937
Flags with carried forward coverage won't be shown. Click here to find out more. |
| ```yaml | ||
|
|
||
| name: bicep build and deploy | ||
|
|
||
| on: push | ||
|
|
||
| jobs: | ||
| bicep-build-and-deploy: | ||
| name: bicep build and deploy | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| # Checks out a copy of your repository on the ubuntu-latest machine | ||
| - name: Checkout code | ||
| uses: actions/checkout@v2 | ||
|
|
||
| # Install the latest release of the bicep CLI | ||
| - name: Install bicep CLI | ||
| run: | | ||
| curl -Lo bicep https://github.com/Azure/bicep/releases/latest/download/bicep-linux-x64 | ||
| chmod +x ./bicep | ||
| sudo mv ./bicep /usr/local/bin/bicep | ||
| bicep --help |
There was a problem hiding this comment.
Nice! Do you think it's also worth showing an example of CI (vs CD) - just the build step?
There was a problem hiding this comment.
meaning have a separate example that just goes to line 42?
There was a problem hiding this comment.
Exactly. Feels trivially similar, but also serves a different purpose. I'm in two minds about whether it's worthwhile to include.
There was a problem hiding this comment.
I added a comment to point out where "CI" transitions into "CD", but for now I feel like it's overkill to go with a separate file
.github/PULL_REQUEST_TEMPLATE.md
Outdated
| @@ -0,0 +1,20 @@ | |||
| # Contributing a Pull Request | |||
|
|
|||
| If you haven't already, read the full [contribution guide](../CONTRIBUTING.md). Once you are done and ready to submit your PR, run through the relevant checklist below. | |||
There was a problem hiding this comment.
Can you add something like this? "The contribution guide may have changed since the last time you read it."
No description provided.