Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Bicep CLI parameters using camel case #12469

Merged
merged 2 commits into from Nov 16, 2023

Conversation

shenglol
Copy link
Contributor

@shenglol shenglol commented Nov 15, 2023

Added new CLI parameters that use kebab case to replace the existing ones using camel case. While those parameters with wrong casing have been excluded from the help message, their implementation remains intact to facilitate a soft deprecation process. A warning message will be printed if any of the deprecated parameters are used by the user.

Closes #12117.

Microsoft Reviewers: Open in CodeFlow

Copy link
Contributor

github-actions bot commented Nov 15, 2023

Test this change out locally with the following install scripts (Action run 6894943667)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 6894943667
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 6894943667"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 6894943667
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 6894943667"

Copy link
Contributor

github-actions bot commented Nov 15, 2023

Test Results

     132 files  +       1       132 suites  +1   4h 17m 25s ⏱️ +2s
10 859 tests +     36  10 857 ✔️ +     35  0 💤 ±0  2 +1 
52 359 runs  +6 242  52 357 ✔️ +6 241  0 💤 ±0  2 +1 

For more details on these failures, see this check.

Results for commit 2c98c74. ± Comparison against base commit 603059c.

♻️ This comment has been updated with latest results.

@shenglol shenglol merged commit 6bc34da into main Nov 16, 2023
45 of 47 checks passed
@shenglol shenglol deleted the shenglol/normalize-cli-param-casing branch November 16, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do we deprecate camel-cased arguments and add new kebab-cased versions?
2 participants