Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for importing variables that enclose synthesized variables #12473

Merged
merged 1 commit into from Nov 16, 2023

Conversation

jeskew
Copy link
Contributor

@jeskew jeskew commented Nov 15, 2023

Resolves #12464

Import closure calculation is not currently taking "synthesized" variables (i.e., the results of functions like loadJsonContent) into account.

Microsoft Reviewers: Open in CodeFlow

Copy link
Contributor

github-actions bot commented Nov 15, 2023

Test this change out locally with the following install scripts (Action run 6894311504)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 6894311504
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 6894311504"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 6894311504
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 6894311504"

Copy link
Contributor

github-actions bot commented Nov 15, 2023

Test Results

     141 files  +       9       141 suites  +9   4h 49m 10s ⏱️ - 6m 13s
10 861 tests +       2  10 860 ✔️ +       3  0 💤 ±0  1  - 1 
55 226 runs  +2 867  55 225 ✔️ +2 868  0 💤 ±0  1  - 1 

For more details on these failures, see this check.

Results for commit 0f63194. ± Comparison against base commit 2a19a18.

♻️ This comment has been updated with latest results.

@jeskew jeskew merged commit f79e257 into main Nov 16, 2023
46 of 47 checks passed
@jeskew jeskew deleted the jeskew/12464 branch November 16, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants