Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding msi and rbac template #1260

Merged
merged 6 commits into from Jan 7, 2021
Merged

Conversation

Saglodha
Copy link
Contributor

@Saglodha Saglodha commented Jan 4, 2021

Adding bicep template to create user MSI and associate RBAC role to MSI

Copy link
Collaborator

@alex-frankel alex-frankel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small tweak

@codecov-io
Copy link

codecov-io commented Jan 7, 2021

Codecov Report

Merging #1260 (0bd55b2) into main (137c908) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1260      +/-   ##
==========================================
- Coverage   94.49%   94.48%   -0.01%     
==========================================
  Files         336      338       +2     
  Lines       16835    16990     +155     
  Branches       14       14              
==========================================
+ Hits        15908    16053     +145     
- Misses        927      937      +10     
Flag Coverage Δ
dotnet 95.02% <ø> (-0.02%) ⬇️
typescript 27.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Bicep.Core/Emit/ExpressionConverter.cs 97.10% <0.00%> (ø)
src/Bicep.Core/Diagnostics/DiagnosticBuilder.cs 100.00% <0.00%> (ø)
src/Bicep.Core/Emit/ResourceDependencyVisitor.cs 94.44% <0.00%> (ø)
...Bicep.Core/Syntax/ParenthesizedExpressionSyntax.cs 100.00% <0.00%> (ø)
...Bicep.Core/TypeSystem/DeployTimeConstantVisitor.cs 95.09% <0.00%> (ø)
...re/TypeSystem/DeployTimeConstantVariableVisitor.cs 83.33% <0.00%> (ø)
src/Bicep.Core/Parsing/Parser.cs 95.22% <0.00%> (+0.01%) ⬆️
....LangServer/Completions/BicepCompletionProvider.cs 97.35% <0.00%> (+0.33%) ⬆️
src/Bicep.Core/Emit/EmitLimitationCalculator.cs 82.50% <0.00%> (+0.44%) ⬆️
src/Bicep.Core/Parsing/TextSpan.cs 95.58% <0.00%> (+1.47%) ⬆️

@Saglodha
Copy link
Contributor Author

Saglodha commented Jan 7, 2021

@alex-frankel , Thanks for the suggestions. I have updated the templates.

@alex-frankel alex-frankel merged commit 3351f55 into Azure:main Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants