Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include required mark for parameters that doesn't have a default value #12749

Conversation

polatengin
Copy link
Member

@polatengin polatengin commented Dec 13, 2023

Fixes #12039

Adding (Required) text to the parameter title when the parameter doesn't have a default value;

Screenshot of a .bicepparam file with a (Required) parameter shown;

image

Screenshot of a .bicepparam file with a not (Required) parameter shown;

image

Just like submodule parameters in .bicep files has (Required) text if they don't have a default value;

Screenshot of a sample .bicep file;

image

Microsoft Reviewers: Open in CodeFlow

Copy link
Contributor

github-actions bot commented Dec 13, 2023

Test this change out locally with the following install scripts (Action run 7212755481)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 7212755481
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 7212755481"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 7212755481
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 7212755481"

Copy link
Contributor

Test Results

       66 files   -        33         66 suites   - 33   1h 22m 54s ⏱️ - 1h 41m 49s
10 426 tests  -        15  10 425 ✔️  -        15  1 💤 ±0  0 ±0 
25 347 runs   - 12 672  25 345 ✔️  - 12 671  2 💤  - 1  0 ±0 

Results for commit 3877f4b. ± Comparison against base commit 460934a.

@polatengin polatengin merged commit e1e66df into main Dec 14, 2023
44 checks passed
@polatengin polatengin deleted the 12039-bicepparam-parameter-name-completions-should-show-which-are-required branch December 14, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

.bicepparam parameter name completions should show which are required
2 participants