Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code lenses to switch between bicep and JSON module source #12762

Merged
merged 2 commits into from Dec 17, 2023

Conversation

StephenWeatherford
Copy link
Contributor

@StephenWeatherford StephenWeatherford commented Dec 15, 2023

Fixes #12757

No source was published:
image

Showing module's main.bicep source:
image

After clicking on "Show compiled JSON":
image

Microsoft Reviewers: Open in CodeFlow

@StephenWeatherford StephenWeatherford marked this pull request as draft December 15, 2023 20:11
Copy link
Contributor

github-actions bot commented Dec 15, 2023

Test this change out locally with the following install scripts (Action run 7236318404)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 7236318404
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 7236318404"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 7236318404
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 7236318404"

@StephenWeatherford StephenWeatherford force-pushed the sw/view-sources-header.with-codelens branch 3 times, most recently from 568ed51 to 1ab8e57 Compare December 15, 2023 20:26
Copy link
Contributor

github-actions bot commented Dec 15, 2023

Test Results

       66 files   -        33         66 suites   - 33   29m 55s ⏱️ - 21m 50s
10 436 tests  -          4  10 436 ✔️  -          4  0 💤 ±0  0 ±0 
25 367 runs   - 12 649  25 367 ✔️  - 12 649  0 💤 ±0  0 ±0 

Results for commit 273fd6c. ± Comparison against base commit 5c0d0fe.

♻️ This comment has been updated with latest results.

@StephenWeatherford StephenWeatherford force-pushed the sw/view-sources-header.with-codelens branch from 1ab8e57 to 35a9964 Compare December 15, 2023 21:13
@StephenWeatherford StephenWeatherford marked this pull request as ready for review December 15, 2023 21:24
@StephenWeatherford StephenWeatherford force-pushed the sw/view-sources-header.with-codelens branch from 35a9964 to ef02c60 Compare December 15, 2023 21:30
@anthony-c-martin
Copy link
Member

I see that @shenglol has already reviewed, so I'll skip the review, but wanted to say, this experience looks super nice!

@StephenWeatherford StephenWeatherford force-pushed the sw/view-sources-header.with-codelens branch from 3550ed5 to 273fd6c Compare December 17, 2023 01:12
@StephenWeatherford StephenWeatherford enabled auto-merge (squash) December 17, 2023 04:18
@StephenWeatherford StephenWeatherford merged commit 5e43858 into main Dec 17, 2023
86 checks passed
@StephenWeatherford StephenWeatherford deleted the sw/view-sources-header.with-codelens branch December 17, 2023 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants