Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add private-endpoint-webapp example #1296

Merged
merged 1 commit into from Jan 11, 2021

Conversation

MCKLMT
Copy link
Contributor

@MCKLMT MCKLMT commented Jan 11, 2021

Contributing a Pull Request

If you haven't already, read the full contribution guide. The guide may have changed since the last time you read it, so please double-check. Once you are done and ready to submit your PR, run through the relevant checklist below.

Contributing to documentation

  • The contribution does not exist in any of the docs in either the root of the docs directory or the specs

Contributing an example

  • I have checked that there is not an equivalent example already submitted
  • I have resolved all warnings and errors shown by the Bicep VS Code extension
  • I have checked that all tests are passing by running dotnet test
  • I have consistent casing for all of my identifiers and am using camelCasing unless I have a justification to use another casing style

Contributing a feature

  • I have opened a new issue for the proposal, or commented on an existing one, and ensured that the bicep maintainers are good with the design of the feature being implemented
  • I have included "Fixes #{issue_number}" in the PR description, so GitHub can link to the issue and close it when the PR is merged
  • I have appropriate test coverage of my new feature

@codecov-io
Copy link

codecov-io commented Jan 11, 2021

Codecov Report

Merging #1296 (44337ff) into main (b9dc190) will increase coverage by 0.45%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1296      +/-   ##
==========================================
+ Coverage   94.57%   95.02%   +0.45%     
==========================================
  Files         341      337       -4     
  Lines       17231    17083     -148     
  Branches       14        0      -14     
==========================================
- Hits        16296    16233      -63     
+ Misses        935      850      -85     
Flag Coverage Δ
dotnet 95.02% <ø> (-0.09%) ⬇️
typescript ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...cep.Core.UnitTests/FileSystem/FileResolverTests.cs 79.31% <0.00%> (-20.69%) ⬇️
.../Bicep.Core.UnitTests/Assertions/BaselineHelper.cs 63.63% <0.00%> (-15.91%) ⬇️
src/Bicep.Core.UnitTests/Utils/CompilerFlags.cs 20.00% <0.00%> (-13.34%) ⬇️
src/Bicep.Core/FileSystem/PathHelper.cs 96.15% <0.00%> (-3.85%) ⬇️
...Bicep.Core.UnitTests/FileSystem/PathHelperTests.cs 100.00% <0.00%> (ø)
src/vscode-bicep/src/utils/logger.ts
src/vscode-bicep/src/language/client.ts
src/vscode-bicep/src/extension.ts
src/vscode-bicep/src/utils/telemetry.ts

@alex-frankel alex-frankel merged commit 2feadc2 into Azure:main Jan 11, 2021
@MCKLMT MCKLMT deleted the private-endpoint-webapp branch January 11, 2021 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants