Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite argument to copyIndex function in imported variables #13098

Merged
merged 1 commit into from Jan 24, 2024
Merged

Conversation

jeskew
Copy link
Contributor

@jeskew jeskew commented Jan 24, 2024

Resolves #12981

This case was already handled when importing copy variables from ARM JSON templates, but not when importing variables declared with for loop expressions from Bicep modules.

Microsoft Reviewers: Open in CodeFlow

Copy link
Contributor

github-actions bot commented Jan 24, 2024

Test this change out locally with the following install scripts (Action run 7647327909)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 7647327909
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 7647327909"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 7647327909
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 7647327909"

Copy link
Contributor

Test Results

    66 files   -     33      66 suites   - 33   24m 37s ⏱️ - 26m 18s
10 756 tests  -     18  10 756 ✅  -     18  0 💤 ±0  0 ❌ ±0 
25 775 runs   - 12 880  25 775 ✅  - 12 880  0 💤 ±0  0 ❌ ±0 

Results for commit 67ff38f. ± Comparison against base commit e321ef8.

@jeskew jeskew enabled auto-merge (squash) January 24, 2024 22:56
@jeskew jeskew merged commit ec98401 into main Jan 24, 2024
44 checks passed
@jeskew jeskew deleted the jeskew/12981 branch January 24, 2024 23:00
asilverman pushed a commit that referenced this pull request Jan 26, 2024
Resolves #12981

This case was already handled when importing copy variables from ARM
JSON templates, but not when importing variables declared with `for`
loop expressions from Bicep modules.
###### Microsoft Reviewers: [Open in
CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/Azure/bicep/pull/13098)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Variable export bug when looping in variable
2 participants