Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't raise missing properties diagnostic if assigned object value has an additional properties type #13272

Merged
merged 2 commits into from Feb 9, 2024

Conversation

jeskew
Copy link
Contributor

@jeskew jeskew commented Feb 8, 2024

Resolves #13247

The type narrowing on objects introduced in #12798 will erroneously raise a missing property diagnostic if the assigned value does not have an explicit property defined for each of the target's required properties, even if the assigned value allows additional properties. This PR updates the type narrowing to consider required properties not to be missing if the assigned value allows arbitrary additional properties.

Microsoft Reviewers: Open in CodeFlow

@jeskew jeskew requested a review from a team February 8, 2024 15:16
Copy link
Contributor

github-actions bot commented Feb 8, 2024

Test this change out locally with the following install scripts (Action run 7840455291)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 7840455291
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 7840455291"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 7840455291
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 7840455291"

Copy link
Contributor

github-actions bot commented Feb 8, 2024

Test Results

    66 files   -     33      66 suites   - 33   24m 45s ⏱️ - 28m 37s
11 008 tests  -     19  11 008 ✅  -     19  0 💤 ±0  0 ❌ ±0 
25 906 runs   - 12 946  25 906 ✅  - 12 946  0 💤 ±0  0 ❌ ±0 

Results for commit 7d9383a. ± Comparison against base commit 83ce3e5.

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Union() issues with 0.25.3
2 participants