Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support existing resource properties with 3rd party types #13487

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Support existing resource properties with 3rd party types #13487

merged 1 commit into from
Feb 28, 2024

Conversation

anthony-c-martin
Copy link
Member

@anthony-c-martin anthony-c-martin commented Feb 27, 2024 •
edited by microsoft-github-policy-service bot

Closes #13465

Microsoft Reviewers: Open in CodeFlow

@anthony-c-martin anthony-c-martin changed the title Fix for issue 13465 Support existing resource properties with 3rd party types Feb 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 27, 2024 •
edited

Test this change out locally with the following install scripts (Action run 8090390962)

VSCode
  • Mac/Linux 
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 8090390962
  • Windows 
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 8090390962"
Azure CLI
  • Mac/Linux 
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 8090390962
  • Windows 
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 8090390962"

@github-actions GitHub Actions
Copy link
Contributor

Test Results

    66 files   -     33      66 suites   - 33   22m 58s ⏱️ - 16m 14s
10 644 tests  -     19  10 643 ✅  -     19  1 💤 ±0  0 ❌ ±0 
25 178 runs   - 12 582  25 176 ✅  - 12 581  2 💤  - 1  0 ❌ ±0 

Results for commit 5bcf2d2. ± Comparison against base commit 07ec2ff.

shenglol
shenglol approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@shenglol shenglol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@anthony-c-martin anthony-c-martin merged commit dbc82a2 into main Feb 28, 2024
44 checks passed
@anthony-c-martin anthony-c-martin deleted the ant/issue13465 branch February 28, 2024 21:00
anthony-c-martin added a commit that referenced this pull request Feb 29, 2024
@anthony-c-martin
Fix for conflict between #13078 and #13487
2577352
@anthony-c-martin anthony-c-martin mentioned this pull request Feb 29, 2024
Merged
anthony-c-martin added a commit that referenced this pull request Feb 29, 2024
@anthony-c-martin
Fix for conflict between #13078 and #13487 (#13496)
415506e 
#13078 and #13487 had incompatible changes and were merged at the same
time. This PR fixes validation on the main branch.

###### Microsoft Reviewers: [Open in
CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/Azure/bicep/pull/13496)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shenglol shenglol shenglol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to access existing resource properties with ThirdPartyResourceTypes
2 participants
@anthony-c-martin @shenglol