Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make some minor improvements to resource filter keywords and add filter keyword support for resource snippets #13731

Merged
merged 3 commits into from Apr 11, 2024

Conversation

StephenWeatherford
Copy link
Contributor

@StephenWeatherford StephenWeatherford commented Mar 27, 2024

Another part of #6387

  1. Hopefully fix update baselines script (unrelated)
  2. vscode handles spaces between than commas
  3. prioritize the actual resource name over the keywords by placing them first
  4. Added a couple more aliases
  5. Implement filtering for snippets:
    a) add snippet description to filter
    b) add resource types and keywords for all resources used in the snippet
Microsoft Reviewers: Open in CodeFlow

Copy link
Contributor

github-actions bot commented Mar 27, 2024

Test this change out locally with the following install scripts (Action run 8651086720)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 8651086720
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 8651086720"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 8651086720
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 8651086720"

Copy link
Contributor

github-actions bot commented Mar 27, 2024

Test Results

    66 files   -     33      66 suites   - 33   22m 20s ⏱️ - 22m 10s
10 748 tests  -     16  10 747 ✅  -     16  1 💤 ±0  0 ❌ ±0 
25 392 runs   - 12 680  25 390 ✅  - 12 679  2 💤  - 1  0 ❌ ±0 

Results for commit 6f6628e. ± Comparison against base commit 63e8819.

♻️ This comment has been updated with latest results.

@StephenWeatherford StephenWeatherford force-pushed the sw/keywords2-snippets branch 9 times, most recently from 3404817 to ba039ea Compare April 1, 2024 18:02
@StephenWeatherford StephenWeatherford changed the title DRAFT Make some minor improvements to resource filter keywords and add filter keyword support for resource snippets Apr 4, 2024
@StephenWeatherford StephenWeatherford marked this pull request as ready for review April 4, 2024 19:53
}

// Add the resource type and its keywords for all resourced used in the snippet
var resourceTypeFilters = resourceTypesUsed.Select(rt => TryGetResourceTypeFilterText(new ResourceTypeReference(rt, null)) ?? rt).ToArray();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: No need to call ToArray.

@StephenWeatherford StephenWeatherford merged commit 9459622 into main Apr 11, 2024
44 checks passed
@StephenWeatherford StephenWeatherford deleted the sw/keywords2-snippets branch April 11, 2024 17:51
@StephenWeatherford
Copy link
Contributor Author

@shenglol Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants