Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify wording for BCP081 warning #13739

Merged
merged 1 commit into from Apr 1, 2024
Merged

Clarify wording for BCP081 warning #13739

merged 1 commit into from Apr 1, 2024

Conversation

anthony-c-martin
Copy link
Member

@anthony-c-martin anthony-c-martin commented Mar 30, 2024

I've seen a few people getting confused by this warning, and not realizing that they can suppress and deploy anyway.

Microsoft Reviewers: Open in CodeFlow

Copy link
Contributor

github-actions bot commented Mar 30, 2024

Test this change out locally with the following install scripts (Action run 8514491197)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 8514491197
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 8514491197"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 8514491197
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 8514491197"

Copy link
Contributor

github-actions bot commented Mar 30, 2024

Test Results

    65 files   -     34      65 suites   - 34   22m 16s ⏱️ - 16m 55s
10 723 tests  -     20  10 721 ✅  -     20  2 💤 ±0  0 ❌ ±0 
25 296 runs   - 12 713  25 292 ✅  - 12 711  4 💤  - 2  0 ❌ ±0 

Results for commit 121edf4. ± Comparison against base commit dba7d80.

♻️ This comment has been updated with latest results.

@anthony-c-martin anthony-c-martin changed the title Clarify wording for BCP081 Clarify wording for BCP081 warning Apr 1, 2024
@anthony-c-martin anthony-c-martin merged commit c92487e into main Apr 1, 2024
44 checks passed
@anthony-c-martin anthony-c-martin deleted the ant/bcp081 branch April 1, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants