Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to fix 13333 #13788

Merged
merged 1 commit into from Apr 10, 2024
Merged

Try to fix 13333 #13788

merged 1 commit into from Apr 10, 2024

Conversation

StephenWeatherford
Copy link
Contributor

@StephenWeatherford StephenWeatherford commented Apr 5, 2024

Fixes #13333 (hopefully)

The behavior in WSL seems to be weird - I'm getting back a filename of "bicepconfig.json.bicepconfig.json", making it impossible to get past the save dialog (since it requires the filename to be "bicepconfig.json".

Removing the filter (which is kinda weird anyway being used as a filename and not an extension) doesn't have much effect on non-WSL, simply meaning the dialog has "All Files" in the filter:

image

Copy link
Contributor

github-actions bot commented Apr 5, 2024

Test this change out locally with the following install scripts (Action run 8637644622)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 8637644622
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 8637644622"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 8637644622
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 8637644622"

Copy link
Contributor

github-actions bot commented Apr 5, 2024

Test Results

    66 files   -     33      66 suites   - 33   23m 7s ⏱️ - 28m 2s
10 744 tests  -     20  10 743 ✅  -     19  1 💤 ±0  0 ❌  - 1 
25 384 runs   - 12 688  25 382 ✅  - 12 686  2 💤  - 1  0 ❌  - 1 

Results for commit 3aabda9. ± Comparison against base commit 57dfcbe.

♻️ This comment has been updated with latest results.

@StephenWeatherford StephenWeatherford merged commit 1f3a4ad into main Apr 10, 2024
44 checks passed
@StephenWeatherford StephenWeatherford deleted the sw/wsl branch April 10, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When creating "bicepconfig.json" from VSCode using WSL
2 participants