-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Formatting rule improvements #13945
Formatting rule improvements #13945
Conversation
Test this change out locally with the following install scripts (Action run 8927734929) VSCode
Azure CLI
|
@@ -637,18 +647,63 @@ private IEnumerable<Document> LayoutParenthesizedTypeSyntax(ParenthesizedTypeSyn | |||
this.LayoutMany(leadingNodes) | |||
.Where(x => x != HardLine); // Remove empty lines between decorators. | |||
|
|||
private IEnumerable<Document> LayoutCommaSeparatedArguments<T>(ImmutableArray<SyntaxBase> children, ImmutableArray<T> arguments) | |||
private Document? LayoutFunctionTailObjectOrArrayArgumentSyntax(ImmutableArray<FunctionArgumentSyntax> argumentSyntaxes) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: "layout" is a noun, "lay out" is a verb. But it is a free country, so you decide.... :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah good catch. Will probably change all occurrence of Layout...
to LayOut...
in a separate PR.
Updated two formatting rules based on user feedback. Main changes:
if
expression on a different line unless there is a single-line comment between=
andif
.Closes #13676.
Microsoft Reviewers: Open in CodeFlow