Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ResourceGroup and SubscriptionId fields #1433

Merged
merged 6 commits into from Feb 3, 2021

Conversation

TSunny007
Copy link
Contributor

Fixes #145 #1391

@codecov-io
Copy link

Codecov Report

Merging #1433 (7420292) into main (bd8bbb5) will increase coverage by 0.42%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1433      +/-   ##
==========================================
+ Coverage   94.70%   95.13%   +0.42%     
==========================================
  Files         352      348       -4     
  Lines       18536    18406     -130     
  Branches       14        0      -14     
==========================================
- Hits        17555    17511      -44     
+ Misses        981      895      -86     
Flag Coverage Δ
dotnet 95.13% <100.00%> (-0.07%) ⬇️
typescript ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../Bicep.Core/TypeSystem/Az/AzResourceTypeFactory.cs 92.06% <ø> (ø)
src/Bicep.Core.IntegrationTests/ScenarioTests.cs 100.00% <100.00%> (ø)
...Bicep.Core/TypeSystem/Az/AzResourceTypeProvider.cs 98.86% <100.00%> (+0.14%) ⬆️
.../Bicep.Core.UnitTests/Assertions/BaselineHelper.cs 63.63% <0.00%> (-15.91%) ⬇️
...cep.Core.UnitTests/FileSystem/FileResolverTests.cs 88.23% <0.00%> (-8.83%) ⬇️
src/Bicep.Core/FileSystem/PathHelper.cs 96.15% <0.00%> (-3.85%) ⬇️
src/Bicep.Core.UnitTests/Utils/OutputHelper.cs 96.55% <0.00%> (-3.45%) ⬇️
src/Bicep.Core.UnitTests/Utils/CompilerFlags.cs 33.33% <0.00%> (ø)
...Bicep.Core.UnitTests/FileSystem/PathHelperTests.cs 100.00% <0.00%> (ø)
src/vscode-bicep/src/utils/logger.ts
... and 3 more

Copy link
Member

@anthony-c-martin anthony-c-martin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

Copy link
Member

@anthony-c-martin anthony-c-martin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TSunny007 TSunny007 merged commit b95f220 into main Feb 3, 2021
@TSunny007 TSunny007 deleted the tsunkaraneni/naiveNestedDeployments branch February 3, 2021 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support "naive" nested deployments
3 participants