Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FAQ to readme, small example tweaks #431

Merged
merged 3 commits into from
Sep 3, 2020
Merged

Conversation

alex-frankel
Copy link
Collaborator

No description provided.

global.json Outdated
@@ -6,7 +6,7 @@
},
"sdk": {
"comment": "Need to use a particular version to ensure consistency across machines no matter what SDK versions they have installed.",
"version": "3.1.301",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forgot to remove this, but should I?

@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2020

Codecov Report

Merging #431 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #431   +/-   ##
=======================================
  Coverage   91.93%   91.93%           
=======================================
  Files         199      199           
  Lines        6708     6708           
=======================================
  Hits         6167     6167           
  Misses        541      541           
Flag Coverage Δ
#dotnet 91.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@majastrz
Copy link
Member

majastrz commented Sep 3, 2020

@alex-frankel Really good explanation, btw.

@alex-frankel alex-frankel merged commit e34cc6c into master Sep 3, 2020
@alex-frankel alex-frankel deleted the alfran/readmeAndThings branch September 3, 2020 02:21
@rzand
Copy link

rzand commented Sep 9, 2020

Hi, I just had a first look at bicep.
In order to be able to deploy the template created from the bicep/docs/examples/101/aks/main.bicep I had to add
count: agentCount
after line 36.
I wanted to let you know.
Andrea

@alex-frankel
Copy link
Collaborator Author

thanks! fixing it with #481

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants