Provide remove unused parameter/variable as quickfix. Fixes #5613

[nilshedstrom]

This PR adds quickfixes for the linter rules no-unused-vars and no-unused-vars as suggested in issue #5613.

Because of failing unit tests I decided not provide linter rules no-unused-vars and no-unused-params for invalid parameters/variables (missing names)

@StephenWeatherford @majastrz

[anthony-c-martin]

I think there are some issues in how multiline statements and statements with leading/trailing comments are handled. Here are some edge cases that repro issues and would be good to add as test cases:

var adsf = 'asdf' /* 
adf 
*/

var asdf = {
  abc: 'def'
}

var abcd = concat('foo',/*
*/'bar')

var multiline = '''
This
is
a
multiline
'''

@description('''
''')
var asdf = 'asdf'

var foo = 'asdf' // asdef

/* asdfds */ var foo = 'asdf'

#disable-next-line foo
param string asdf = 123

/* asdf */ var foo = 'asdf'
var bar = 'asdf'

[nilshedstrom]

@StephenWeatherford can you clearify what kind of response you are waiting for (what am I supposed to fix)
I did fix the comment from @anthony-c-martin

[StephenWeatherford]

Thanks. Looked like there were still unresolved comments. GitHub's CR process is very lacking. I'll take a look. Always feel free to nudge if it looks like something is getting forgotten.

[StephenWeatherford]

Sorry for the delay, haven't forgotten.

[StephenWeatherford]

A few minor changes requested

[nilshedstrom]

A few minor changes requested

I did the changes you requested.

[StephenWeatherford]

Ideally, "type" would be an enum, not a string.

I'll leave it up to you if you want to update. Thanks for adding this!

[StephenWeatherford]

Re-running tests.

[StephenWeatherford]

Looks like some of the "invalid variable" filter has regressed in the test baseline:

[StephenWeatherford]

@nilshedstrom I'll be OOF starting tomorrow for a couple of weeks. If I don't respond, @bhsubra can help finish the review.

[StephenWeatherford]

Hm, looks like we're getting a null ref exception during the tests in an unrelated rule:

Expected AssertionExtensions {"[linter-internal-error (Warning)] Analyzer 'core/no-hardcoded-location' encountered an unexpected exception. Object reference not set to an instance of an object.", "[BCP152 (Error)] Function "resourceId" cannot be used as a decorator.", "[no-unused-params (Warning)] Parameter "foo" is declared but never used.", "[BCP152 (Error)] Function "concat" cannot be used as a decorator.", "[no-unused-vars (Warning)] Variable "bar" is declared but never used.", "[BCP152 (Error)] Function "environment" cannot be used as a decorator.", "[BCP081 (Warning)] Resource type "Microsoft.Network/virtualNetworks@2020-06-01" does not have types available.", "[BCP152 (Error)] Function "union" cannot be used as a decorator.", "[BCP152 (Error)] Function "guid" cannot be used as a decorator."} to not have any items matching (x.Code == "linter-internal-error") because Should never get LinterAnalyzer.LinterRuleInternalError, but found {"[linter-internal-error (Warning)] Analyzer 'core/no-hardcoded-location' encountered an unexpected exception. Object reference not set to an instance of an object."}.

Re-running test. Never seen that before.

[StephenWeatherford]

A couple of suggested but not required changes. We just need to make sure the tests pass.

[StephenWeatherford]

Manually fixed merge conflicts

[StephenWeatherford]

@nilshedstrom Thanks! Looks great!