Preserve literal elements in string union types #6933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majastrz
reviewed
May 23, 2022
… string is loaded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes an optimization in the type loader that cast union types with a mixture of string literals and
stringdown to the base string type. The purpose of this change is to enable completions on extensible enums (which take the form of'some' | 'literal' | 'values' | string); type checking is unaffected, as'some' | 'literal' | 'values' | stringandstringhave the same domain.This is a companion to (but not dependent on) Azure/bicep-types-az#828
Microsoft Reviewers: Open in CodeFlow