Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bicep deploy - additional params support #7030

Merged
merged 25 commits into from
Jun 7, 2022

Conversation

bhsubra
Copy link
Contributor

@bhsubra bhsubra commented Jun 2, 2022

Fixes:
#6159
#7005
#7019
#7024
#6773

Changes in the PR include:

  • Support for additional/missing parameters. Note: we only support parameters of type int, bool and string. Arrays and objects are ignored for now because of the complexity involved
  • Missing params – these are parameters that are not specified in parameters file and don’t have a default value in bicep file. We will show an input box that will let the user input value for missing params
  • Params with default values – these are parameters that are specified in bicep file with default value. We will provide an input box, prefilled with default value from bicep file. User can either press enter to use the default or provide a new value. Note: Expression strings are handled differently. We will provide three options here: 1. Use the expression as is 2. Provide a new value 3. Leave blank. Note: In case of (1), value will not be written to parameters file
  • After iterating through all the parameters, the user can either choose to create a new parameters file, if it doesn’t exist or update an existing file. Note: secure parameters will be sent across to the azure sdk and used in deployment, but will not be written to parameters file
  • UI changes to show all the .json/.jsonc files from the workspace along with current – None and Browse options
  • Added telemetry
  • Added unit tests
Microsoft Reviewers: Open in CodeFlow

@bhsubra
Copy link
Contributor Author

bhsubra commented Jun 2, 2022

@ucheNkadiCode, we discussed about ignoring unused parameters. I think we need to support it.
File with below contents is deployable:

param test string = 'abc'

So for the below param we need to show input box to accept value from user:

param test string

Let me know if you disagree.

@shenglol , thanks for finding the issue. I fixed it here:
27c2b1e

@bhsubra bhsubra requested a review from shenglol June 3, 2022 17:28
@bhsubra bhsubra linked an issue Jun 6, 2022 that may be closed by this pull request
@bhsubra bhsubra merged commit 44bc2d0 into main Jun 7, 2022
@bhsubra bhsubra deleted the dev/bhsubra/BicepDeployParamsSupport branch June 7, 2022 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bicep deploy - support multiple deployment operations
4 participants