Add syntax rewriter framework and some decompiler simplification rewriters #953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #953 +/- ##
==========================================
- Coverage 94.33% 94.24% -0.09%
==========================================
Files 316 326 +10
Lines 14771 15575 +804
Branches 12 12
==========================================
+ Hits 13934 14679 +745
- Misses 837 896 +59
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
You have an empty file called InvalidOperationException.cs btw. |
majastrz
reviewed
Nov 20, 2020
majastrz
reviewed
Nov 20, 2020
| return syntax; | ||
| } | ||
|
|
||
| // TODO what to do with lexerDiagnostics? |
There was a problem hiding this comment.
lexerDiagnostics [](start = 36, length = 16)
This makes me wonder if we need to have errors on tokens that get collected like parse errors. (Most tokens don't have errors so it could also be a new ErrorToken class derived from Token to avoids allocating extra space for mostly null pointers.)
majastrz
reviewed
Nov 20, 2020
majastrz
reviewed
Nov 20, 2020
Thanks for the heads-up :) Omnisharp makes it annoyingly easy to accidentally do that... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'{parent.name}/child'style syntaxCloses [Decompilation] Simplifications to decompilation output #965
Closes [Decompilation] Automatically fix parent-child resource name dependencies #964
Preview these changes on the quickstart repo here.