Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Span of ProgramSyntax #954

Merged
merged 1 commit into from
Nov 20, 2020
Merged

Fix Span of ProgramSyntax #954

merged 1 commit into from
Nov 20, 2020

Conversation

shenglol
Copy link
Contributor

Closes #926.

@codecov-io
Copy link

codecov-io commented Nov 19, 2020

Codecov Report

Merging #954 (a0ac0f4) into main (14ef033) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #954      +/-   ##
==========================================
- Coverage   94.33%   94.33%   -0.01%     
==========================================
  Files         316      316              
  Lines       14774    14771       -3     
  Branches       12       12              
==========================================
- Hits        13937    13934       -3     
  Misses        837      837              
Flag Coverage Δ
dotnet 94.93% <100.00%> (-0.01%) ⬇️
typescript 25.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Bicep.Core/Syntax/ProgramSyntax.cs 100.00% <100.00%> (ø)
...gServer/Handlers/BicepDocumentFormattingHandler.cs 88.00% <100.00%> (ø)

Copy link
Member

@anthony-c-martin anthony-c-martin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! Would you mind sharing your repro on the issue, out of interest?

Copy link
Member

@majastrz majastrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was the issue limited to only formatting? I thought it happened in other scenarios as well.

@shenglol
Copy link
Contributor Author

Great catch! Would you mind sharing your repro on the issue, out of interest?

Sure will do.

@shenglol
Copy link
Contributor Author

Was the issue limited to only formatting? I thought it happened in other scenarios as well.

No formatting actually works fine, and it only happens in other scenarios. I've noticed a similar bug when I was testing the formatter so I added FullSpan to ProgramSyntax for the formatting handler to use, but I didn't realize it's a broader issue.

@shenglol shenglol merged commit 3ceef99 into main Nov 20, 2020
@shenglol shenglol deleted the shenglol/fix-#926 branch November 20, 2020 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TextDocumentSyncHandler and other document request handlers likely getting out of sync
4 participants