fix(storage): Improve storage layer for projects #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, storage did not need to know much about projects. This adds better support for projects to the storage layer, and adds a CreateProject function.
adamreese
approved these changes
Jun 12, 2018
pkg/storage/mock/storage.go
Outdated
| } | ||
| } | ||
|
|
||
| // Store implements the storage.Storage interface, but returns mock data. | ||
| type Store struct { | ||
| // Project is the project you want returned. | ||
| Project *brigade.Project | ||
| //Project *brigade.Project |
technosophos
force-pushed
the
fix/api-better-project-support
branch
from
f3a6d30
to
9cdbb9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, storage did not need to know much about projects. This adds
better support for projects to the storage layer, and adds a
CreateProject function.