fix(worker): handle transient faults (#625) #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix(worker): handle JSON.parse exception caused by transient faults in watch feat(worker): support KUBECONFIG (feedback from #596)
|
The code looks good, but I think we need to run a manual test. |
radu-matei
reviewed
Sep 11, 2018
radu-matei
reviewed
Sep 11, 2018
radu-matei
reviewed
Sep 11, 2018
radu-matei
reviewed
Sep 11, 2018
radu-matei
reviewed
Sep 11, 2018
Make sure watch stream stay connected
|
@technosophos Any clue on when this might be tested in order to get merged? I hope to see this available in the next release if possible. |
|
If @radu-matei has no additional concerns, I think we can mark this as good and merge it. |
|
Ping @radu-matei |
|
Oups, sorry.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(worker): handle transient faults (#625)
fix(worker): handle JSON.parse exception caused by transient faults in
watch
feat(worker): support KUBECONFIG (feedback from #596)