Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename arm tests to resourcemanager #612

Merged
merged 5 commits into from
Jul 1, 2024
Merged

rename arm tests to resourcemanager #612

merged 5 commits into from
Jul 1, 2024

Conversation

pshao25
Copy link
Member

@pshao25 pshao25 commented Jun 28, 2024

Arm is in the .gitignore of autorest.csharp repo. This is legacy code so that we don't want to touch it. Therefore we want to rename it to resourcemanager.

Copy link

changeset-bot bot commented Jun 28, 2024

🦋 Changeset detected

Latest commit: 0640729

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@azure-tools/cadl-ranch-specs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@weidongxu-microsoft weidongxu-microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next time, please review the namespace when it is still PR.

It takes time to modify in emitter repo, after dev already added the tests.

Copy link
Member

@msyyc msyyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python feel OK since we have not tested these cases yet.

@pshao25 pshao25 merged commit 6ca2553 into Azure:main Jul 1, 2024
7 checks passed
@pshao25 pshao25 deleted the armTest branch July 1, 2024 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants