Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

Fix keyvault access policy config key and landingzone level #73

Merged
merged 1 commit into from
Jun 4, 2021
Merged

Fix keyvault access policy config key and landingzone level #73

merged 1 commit into from
Jun 4, 2021

Conversation

heidecke
Copy link
Contributor

64

PR Checklist


  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • I ran lint checks locally prior to submission.
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Description

The keyvault_access_policies_azuread_apps currently references the incorrect config key and the azure_devops template is configured at the incorrect level.

Does this introduce a breaking change

  • YES
  • NO

Testing

Running terraform plan should now produce no errors and the apply should now run without error.

@heidecke
Copy link
Contributor Author

Apologies for the closed PR, my fancy git config working against me!

@heidecke
Copy link
Contributor Author

@arnaudlh I'm not sure if the level change was on purpose to account for something else, but these two changes seemed to fix the error in the spirit of your most recent changes.

@arnaudlh arnaudlh added this to the 2106 milestone Jun 4, 2021
@arnaudlh arnaudlh added the bug Something isn't working label Jun 4, 2021
@arnaudlh
Copy link
Member

arnaudlh commented Jun 4, 2021

thanks for the PR @heidecke

@arnaudlh arnaudlh merged commit d553023 into Azure:starter Jun 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants