Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for keyvault_certificates #138

Merged
merged 2 commits into from
Feb 18, 2021
Merged

Add support for keyvault_certificates #138

merged 2 commits into from
Feb 18, 2021

Conversation

hieumoscow
Copy link
Contributor

@hieumoscow hieumoscow commented Feb 17, 2021 •
edited
Loading

Depends on aztfmod/terraform-azurerm-caf#277

Issue-id

PR Checklist

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • I ran lint checks locally prior to submission.
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Description

Does this introduce a breaking change

  • YES
  • NO

Testing

@arnaudlh arnaudlh added the bug Something isn't working label Feb 18, 2021
@arnaudlh arnaudlh added this to the 2102 milestone Feb 18, 2021
@arnaudlh arnaudlh changed the title add support for keyvault_certificates Add support for keyvault_certificates Feb 18, 2021
@arnaudlh arnaudlh merged commit 9a66407 into master Feb 18, 2021
@arnaudlh arnaudlh deleted the keyvault_certificates branch February 18, 2021 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnaudlh arnaudlh arnaudlh approved these changes

@LaurentLesle LaurentLesle Awaiting requested review from LaurentLesle

Assignees

@hieumoscow hieumoscow

Labels
bug Something isn't working
Projects
None yet
Milestone
2102
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hieumoscow @arnaudlh