Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2104.3 #172

Merged
merged 3 commits into from
Apr 30, 2021
Merged

2104.3 #172

merged 3 commits into from
Apr 30, 2021

Conversation

LaurentLesle
Copy link
Contributor

Issue-id

PR Checklist

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • I ran lint checks locally prior to submission.
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Description

Does this introduce a breaking change

  • YES
  • NO

Testing

@LaurentLesle LaurentLesle added the bug Something isn't working label Apr 30, 2021
@LaurentLesle LaurentLesle self-assigned this Apr 30, 2021
@LaurentLesle LaurentLesle linked an issue Apr 30, 2021 that may be closed by this pull request
Cannot assign a principal_id to a custom role in eslz #173
Closed
@LaurentLesle LaurentLesle linked an issue Apr 30, 2021 that may be closed by this pull request
remote objects missing for azuread_apps, azuread_users and azuread_groups #174
Closed
@arnaudlh arnaudlh added this to the 2104 milestone Apr 30, 2021
arnaudlh
arnaudlh approved these changes Apr 30, 2021
View reviewed changes
Copy link
Member

@arnaudlh arnaudlh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@arnaudlh arnaudlh merged commit 0b6d63e into master Apr 30, 2021
@arnaudlh arnaudlh deleted the 2104.3 branch August 11, 2021 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnaudlh arnaudlh arnaudlh approved these changes

Assignees

@LaurentLesle LaurentLesle

Labels
bug Something isn't working
Projects
None yet
Milestone
2104
2 participants
@LaurentLesle @arnaudlh