Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sovereign cloud endpoints and suffix environment variables (part 2) #184

Merged
merged 3 commits into from
May 27, 2021

Conversation

davesee
Copy link
Contributor

@davesee davesee commented May 21, 2021

Issue-183

PR Checklist


  • [ NA] I have updated the documentation accordingly.
  • [ NA] I have added tests to cover my changes.
  • [Pending] All new and existing tests passed.
  • [x ] My code follows the code style of this project.
  • I ran lint checks locally prior to submission.
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Description

This PR resolves part one of the bug issue. See issue for other parts.

Added complex cloud variable to store endpoints and suffixes from the logged in cloud

  • Retrieve az cloud show endpoints and suffixes
  • Convert to variables to be passed to the modules
  • Added Azure Public Cloud default values in the case the code is run without Rover
    • Can change to null defaults but opted for greater modularity.

closes #183

Does this introduce a breaking change

  • YES
  • NO

Testing

Use Azure update, Login to AzureUSGovernment and deploy a MSSQL db with db_permissions to see appropriate cloud URI in use.

@ghost
Copy link

ghost commented May 21, 2021

CLA assistant check
All CLA requirements met.

@arnaudlh arnaudlh added the enhancement New feature or request label May 26, 2021
@arnaudlh arnaudlh added this to the 2105 milestone May 26, 2021
@arnaudlh arnaudlh changed the base branch from master to AL-2105 May 27, 2021 05:02
@arnaudlh arnaudlh merged commit a76b84a into Azure:AL-2105 May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Add soveregin cloud endpoints and suffixes for modules (part 2)
2 participants