Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tag type in baseline v2 addon #223

Merged
merged 1 commit into from
Jul 12, 2021
Merged

Update tag type in baseline v2 addon #223

merged 1 commit into from
Jul 12, 2021

Conversation

hieumoscow
Copy link
Contributor

Issue-id

PR Checklist

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • I ran lint checks locally prior to submission.
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Description

Does this introduce a breaking change

  • YES
  • NO

Testing

@hieumoscow hieumoscow self-assigned this Jul 12, 2021
@arnaudlh arnaudlh changed the title Update tagtype in baseline v2 addon Update tag type in baseline v2 addon Jul 12, 2021
@hieumoscow hieumoscow merged commit cf57190 into master Jul 12, 2021
@hieumoscow hieumoscow deleted the HN-v2-addon-tagtype branch July 12, 2021 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnaudlh arnaudlh arnaudlh approved these changes

@LaurentLesle LaurentLesle Awaiting requested review from LaurentLesle

Assignees

@hieumoscow hieumoscow

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hieumoscow @arnaudlh