Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nat_gateway module #224

Merged
merged 2 commits into from
Jul 15, 2021
Merged

Add nat_gateway module #224

merged 2 commits into from
Jul 15, 2021

Conversation

naeemdhby
Copy link

@naeemdhby naeemdhby commented Jul 14, 2021 •
edited
Loading

Nat gateway module

PR Checklist

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • I ran lint checks locally prior to submission.
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Description

Does this introduce a breaking change

  • YES
  • NO

Testing

@ghost
Copy link

ghost commented Jul 14, 2021 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@arnaudlh arnaudlh added this to the 2107 milestone Jul 14, 2021
@arnaudlh arnaudlh added the enhancement New feature or request label Jul 14, 2021
@arnaudlh arnaudlh self-requested a review July 14, 2021 09:44
arnaudlh
arnaudlh approved these changes Jul 14, 2021
View reviewed changes
Copy link
Member

@arnaudlh arnaudlh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arnaudlh arnaudlh merged commit 51297e4 into Azure:master Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnaudlh arnaudlh arnaudlh approved these changes

Assignees

@naeemdhby naeemdhby

Labels
enhancement New feature or request
Projects
None yet
Milestone
2107
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@naeemdhby @arnaudlh