Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add vhub connection vnet id support #227

Merged
merged 6 commits into from
Aug 12, 2021
Merged

add vhub connection vnet id support #227

merged 6 commits into from
Aug 12, 2021

Conversation

jorseng
Copy link
Contributor

@jorseng jorseng commented Jul 22, 2021

Issue-id

PR Checklist

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • I ran lint checks locally prior to submission.
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Description

Does this introduce a breaking change

  • YES
  • NO

Testing

@jorseng jorseng added the enhancement New feature or request label Jul 22, 2021
@jorseng jorseng self-assigned this Jul 22, 2021
@arnaudlh arnaudlh changed the base branch from master to patch.5.4.2 August 12, 2021 00:46
arnaudlh
arnaudlh approved these changes Aug 12, 2021
View reviewed changes
Copy link
Member

@arnaudlh arnaudlh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arnaudlh arnaudlh added this to the 2108 milestone Aug 12, 2021
@LaurentLesle LaurentLesle merged commit 1a344f6 into patch.5.4.2 Aug 12, 2021
@LaurentLesle LaurentLesle deleted the hub-conn-ct branch August 12, 2021 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaurentLesle LaurentLesle LaurentLesle approved these changes

@arnaudlh arnaudlh arnaudlh approved these changes

Assignees

@jorseng jorseng

Labels
enhancement New feature or request
Projects
None yet
Milestone
2108
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jorseng @LaurentLesle @arnaudlh