Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix subnet_keys role assignment for aks_secure_baseline_v2 #233

Merged
merged 1 commit into from
Aug 12, 2021
Merged

Fix subnet_keys role assignment for aks_secure_baseline_v2 #233

merged 1 commit into from
Aug 12, 2021

Conversation

hieumoscow
Copy link
Contributor

Issue-id

PR Checklist

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • I ran lint checks locally prior to submission.
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Description

Does this introduce a breaking change

  • YES
  • NO

Testing

@hieumoscow hieumoscow self-assigned this Aug 2, 2021
@LaurentLesle LaurentLesle changed the base branch from master to patch.5.4.2 August 11, 2021 11:14
@arnaudlh arnaudlh added the bug Something isn't working label Aug 12, 2021
@arnaudlh arnaudlh added this to the 2108 milestone Aug 12, 2021
@arnaudlh arnaudlh merged commit 4c45999 into patch.5.4.2 Aug 12, 2021
@arnaudlh arnaudlh deleted the HN-aks_secure_baseline_v2-roleassignment branch August 12, 2021 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaurentLesle LaurentLesle LaurentLesle approved these changes

@arnaudlh arnaudlh Awaiting requested review from arnaudlh

Assignees

@hieumoscow hieumoscow

Labels
bug Something isn't working
Projects
None yet
Milestone
2108
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hieumoscow @LaurentLesle @arnaudlh