Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding vmware_clusters and vmware_private_cloud variables #242

Merged
merged 2 commits into from
Aug 17, 2021

Conversation

SergioMiyama
Copy link
Contributor

@SergioMiyama SergioMiyama commented Aug 17, 2021

Issue-id

PR Checklist


  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • I ran lint checks locally prior to submission.
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Description

Does this introduce a breaking change

  • YES
  • NO

Testing

@ghost
Copy link

ghost commented Aug 17, 2021

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ SergioMiyama sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

@arnaudlh arnaudlh changed the base branch from master to patch.5.4.2 August 17, 2021 05:39
Copy link
Contributor

@LaurentLesle LaurentLesle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SergioMiyama

@LaurentLesle LaurentLesle added the enhancement New feature or request label Aug 17, 2021
@LaurentLesle LaurentLesle added this to the 2108 milestone Aug 17, 2021
@arnaudlh arnaudlh changed the title vmware_clustes and vmware_private_cloud variables Adding vmware_clusters and vmware_private_cloud variables Aug 17, 2021
@arnaudlh arnaudlh merged commit 1abc4fe into patch.5.4.2 Aug 17, 2021
@arnaudlh arnaudlh deleted the vmwarecluster-sergio branch August 17, 2021 10:54
@arnaudlh arnaudlh mentioned this pull request Aug 18, 2021
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants