Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to support default global settings key #244

Merged
merged 1 commit into from
Aug 17, 2021
Merged

Update to support default global settings key #244

merged 1 commit into from
Aug 17, 2021

Conversation

seanlok
Copy link
Contributor

@seanlok seanlok commented Aug 17, 2021

Issue-id

PR Checklist

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • I ran lint checks locally prior to submission.
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Description

Does this introduce a breaking change

  • YES
  • NO

Testing

@LaurentLesle LaurentLesle changed the base branch from master to patch.5.4.2 August 17, 2021 10:11
LaurentLesle
LaurentLesle approved these changes Aug 17, 2021
View reviewed changes
Copy link
Contributor

@LaurentLesle LaurentLesle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @seanlok

@LaurentLesle LaurentLesle added the enhancement New feature or request label Aug 17, 2021
@LaurentLesle LaurentLesle added this to the 2108 milestone Aug 17, 2021
@arnaudlh arnaudlh merged commit 4e8b814 into Azure:patch.5.4.2 Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaurentLesle LaurentLesle LaurentLesle approved these changes

Assignees

@seanlok seanlok

Labels
enhancement New feature or request
Projects
None yet
Milestone
2108
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@seanlok @LaurentLesle @arnaudlh