Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update aks-pod-identity-assignment.tf #246

Merged
merged 1 commit into from
Aug 24, 2021

Conversation

nashgongchan
Copy link
Contributor

@nashgongchan nashgongchan commented Aug 22, 2021

Remove Boolean value

Issue-id

PR Checklist


  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • I ran lint checks locally prior to submission.
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Description

Does this introduce a breaking change

  • YES
  • NO

Testing

@LaurentLesle LaurentLesle added the enhancement New feature or request label Aug 24, 2021
@LaurentLesle LaurentLesle added this to the 2108 milestone Aug 24, 2021
Copy link
Contributor

@LaurentLesle LaurentLesle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - clearer. thanks

@arnaudlh arnaudlh merged commit 5666132 into Azure:patch.5.4.2 Aug 24, 2021
@arnaudlh arnaudlh linked an issue Aug 25, 2021 that may be closed by this pull request
@hieumoscow
Copy link
Contributor

hieumoscow commented Aug 26, 2021

Hi @nashgongchan, I made the change before (It used to be like your code) because var.vnets[var.aks_cluster_vnet_key].subnet_keys was a list.
Thus if you supply the above value then we would have the below error.
Reverting this for now as this is breaking one of my customer.

 line 29, in resource "azurerm_role_assignment" "kubelet_subnets_networkcontrib":
│   29:   for_each = lookup(var.vnets[var.aks_cluster_vnet_key], "subnet_keys", { vnet = true })
│     ├────────────────
│     │ var.aks_cluster_vnet_key is "vnet_gitops"
│     │ var.vnets is object with 1 attribute "vnet_gitops"
│ 
│ The given "for_each" argument value is unsuitable: the "for_each" argument
│ must be a map, or set of strings, and you have provided a value of type
│ tuple.
╵

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Invalid for_each set argument
4 participants