Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix baseline network scope role assignment #252

Merged
merged 2 commits into from
Sep 10, 2021
Merged

fix baseline network scope role assignment #252

merged 2 commits into from
Sep 10, 2021

Conversation

jorseng
Copy link
Contributor

@jorseng jorseng commented Sep 10, 2021

Issue-id

PR Checklist

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • I ran lint checks locally prior to submission.
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Description

Does this introduce a breaking change

  • YES
  • NO

Testing

@jorseng jorseng added the bug Something isn't working label Sep 10, 2021
@jorseng jorseng self-assigned this Sep 10, 2021
hieumoscow
hieumoscow approved these changes Sep 10, 2021
View reviewed changes
Copy link
Contributor

@hieumoscow hieumoscow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank @jorseng

@hieumoscow hieumoscow merged commit ee05f94 into master Sep 10, 2021
@arnaudlh arnaudlh deleted the fix-baseline-vnet branch December 9, 2021 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hieumoscow hieumoscow hieumoscow approved these changes

Assignees

@jorseng jorseng

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jorseng @hieumoscow