Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auxiliary tenant is optional when peering in the same tenant #253

Merged
merged 1 commit into from
Sep 23, 2021

Conversation

LaurentLesle
Copy link
Contributor

The add-on can be used to connect a vnet and a vhub in different subscriptions / same tenant or different tenant.
This change adds the support for the same tenant when using azure AD service principals.

virtual_hub_subscription_id = "xxxx"
virtual_hub_tenant_id       = "yyyy"
virtual_hub_lz_key          = "connectivity_virtual_hub1"

virtual_network_subscription_id = "uuuuu"
virtual_network_tenant_id       = "vvvv"

virtual_hub_connections = {
  project2_to_hub1 = {
    name = "project2-to-hub1"
    virtual_hub = {
      lz_key = "connectivity_virtual_hub1"
      key    = "hub1"
    }
    vnet = {
      lz_key   = "project2-resources"
      vnet_key = "project2"
    }
  }
}

@LaurentLesle LaurentLesle added the enhancement New feature or request label Sep 10, 2021
Copy link
Member

@arnaudlh arnaudlh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arnaudlh arnaudlh added this to the 2109 milestone Sep 15, 2021
@LaurentLesle LaurentLesle changed the base branch from master to patch.5.4.4 September 23, 2021 04:19
@LaurentLesle LaurentLesle merged commit ed19125 into patch.5.4.4 Sep 23, 2021
@LaurentLesle LaurentLesle deleted the patch/add-on/vnet_connection branch September 23, 2021 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants