Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to ESLZ 0.3.3 to multiple type of parameters #254

Merged
merged 10 commits into from
Sep 23, 2021

Conversation

LaurentLesle
Copy link
Contributor

@LaurentLesle LaurentLesle commented Sep 16, 2021

This PR adds support for other type value in archetype_config_overrides.tfvars and custom_landing_zones.tfvars

  • value - string value
  • values - list of strings
  • boolean - boolean value
  • integer - integer number
  • hcl_jsonencoded - is a string jsonencoded of an HCL map (see example bellow. you can use terraform console to jsondecode)

Breaking change

require to change list values from

value = ["southeastasia"] to values = ["southeastasia"]

ctsdemo001-corp = {
    display_name               = "Corp"
    parent_management_group_id = "ctsdemo001-landing-zones"
    archetype_config = {
      archetype_id   = "landingzone_corp"
      parameters     = {
        "Allowed-Locations" = {
          "listOfAllowedLocations" = {
            values = [
              "Southeast Asia",
              "East Asia"
            ]
          }
        }
        "aks-capability" = {
          "allowedCapabilities" = {
            values = ["STOP", "KILL", "SIGTERM"]
          }
          "effect" = {
            value = "audit"
          }
          "labelSelector" = {
            hcl_jsonencoded = "{\"matchExpressions\":[{\"key\":\"tier\",\"operator\":\"In\",\"values\":[\"cache\"]},{\"key\":\"environment\",\"operator\":\"NotIn\",\"values\":[\"dev\"]}],\"matchLabels\":{\"component\":\"redis\"}}"
          }
        }
        "aks-authorized-host-port" = {
          effect = {
            value = "audit"
          }
          excludedNamespaces = {
            values = ["kube-system", "gatekeeper-system", "azure-arc"]
          }
          namespaces = {
            values = []
          }
          labelSelector = {
            hcl_jsonencoded = "{}"
          }
          allowHostNetwork = {
            boolean = false
          }
          minPort = {
            integer = 10000
          }
          maxPort = {
            integer = 20000
          }
          excludedContainers = {
            values = ["nginx-ingress"]
          }
        }
      }
      access_control = {}
    }
    subscriptions    = {}
    subscription_ids = []
  }

@LaurentLesle LaurentLesle added enhancement New feature or request breaking-change labels Sep 16, 2021
@LaurentLesle LaurentLesle added this to the 2109 milestone Sep 16, 2021
@LaurentLesle LaurentLesle self-assigned this Sep 16, 2021
@LaurentLesle LaurentLesle linked an issue Sep 16, 2021 that may be closed by this pull request
@LaurentLesle LaurentLesle changed the title Patch/combined parameters Add support to ESLZ 0.3.3 to multiple type of parameters Sep 16, 2021
@LaurentLesle LaurentLesle changed the base branch from master to patch.5.4.4 September 23, 2021 04:16
@LaurentLesle LaurentLesle merged commit 07c5b53 into patch.5.4.4 Sep 23, 2021
@arnaudlh arnaudlh deleted the patch/combined_parameters branch December 9, 2021 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Module version 0.3.3 for caf-eslz addon
2 participants