Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for application_gateway_applications_v1 #259

Merged
merged 8 commits into from
Nov 10, 2021

Conversation

mingheng92
Copy link
Contributor

Issue-id

PR Checklist


  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • I ran lint checks locally prior to submission.
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Description

Does this introduce a breaking change

  • YES
  • NO

Testing

add support for application_gateway_applications_v1
add variable application_gateway_applications_v1
@ghost
Copy link

ghost commented Oct 13, 2021

CLA assistant check
All CLA requirements met.

Copy link
Member

@arnaudlh arnaudlh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arnaudlh arnaudlh added the bug Something isn't working label Nov 4, 2021
@arnaudlh arnaudlh added this to the 2111 milestone Nov 4, 2021
@arnaudlh
Copy link
Member

arnaudlh commented Nov 4, 2021

hi @mingheng92 looks good to me, only need you to accept the Azure CLA and we are good to go!

@arnaudlh arnaudlh merged commit ec5dead into Azure:patch.5.4.4 Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants