This repository has been archived by the owner on Jul 26, 2024. It is now read-only.
Add support for Github service connections #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hi, I'm not clear on how testing is done in this framework yet, so have left those boxes unchecked. If there is a way I can go about adding tests for this change please just point me in the right direction :) |
In order to source pipeline yamls from Github (non public repos), we need to create a service connection. This commit updates the service endpoint functionality to understand a 'type' value. For the existing configs, default type to 'TfsGit' if none is specified. If type is set to 'Github', then use the new logic under azdo_service_endpoint.github.tf to provision the connection. The various values for 'type' are shown at https://registry.terraform.io/providers/microsoft/azuredevops/latest/docs/resources/build_definition#repo_type - however this commit only implements Github. A similar pattern should be possible to implement Bitbucket / GitHubEnterprise. The following shows an example config to use this new functionality: service_endpoints = { github = { endpoint_name = "github_endpoint" type = "Github" project_key = "project_to_add_endpoint_to" keyvault = { lz_key = "launchpad" key = "secrets" secret_name = "github-pat" } } } NOTE: similar to azdo-pat-admin, a Github PAT must be manually created and stored in the keyvault identified in the 'keyvault {}' block above: $ az keyvault secret set --name gitub-pat --vault-name <secrets-vault> --value <pat>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Description
In order to source pipeline yamls from Github (non public repos), we
need to create a service connection.
This commit updates the service endpoint functionality to understand a
'type' value. For the existing configs, default type to 'TfsGit' if none
is specified. If type is set to 'Github', then use the new logic under
azdo_service_endpoint.github.tf to provision the connection.
The various values for 'type' are shown at https://registry.terraform.io/providers/microsoft/azuredevops/latest/docs/resources/build_definition#repo_type - however this commit only implements Github.
A similar pattern should be possible to implement Bitbucket / GitHubEnterprise.
NOTE: similar to azdo-pat-admin, a Github PAT must be manually created
and stored in the keyvault identified in the 'keyvault {}' block:
$ az keyvault secret set --name gitub-pat --vault-name --value
Does this introduce a breaking change
Testing