Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support aad_apps for AZDO service endpoints #266

Merged
merged 1 commit into from
Nov 10, 2021
Merged

Support aad_apps for AZDO service endpoints #266

merged 1 commit into from
Nov 10, 2021

Conversation

brk3
Copy link
Contributor

@brk3 brk3 commented Oct 21, 2021

PR Checklist

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • I ran lint checks locally prior to submission.
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Description

For reasons that are not entirely clear to me yet, CAF Terraform
has two ways of creating service principals:

aad_apps {
  # uses ./modules/azuread/applications
}

or,

azuread_applications {
  # uses ./modules/azuread/applications_v1
}

Also for reasons not yet clear to me, this repo provides two lzs for
configuring AZDO: caf_solution/add-ons/azure_devops and
caf_solution/add-ons/azure_devops_v1

The azure_devops module appears to use aad_apps, while azure_devops_v1
uses azuread_applications. This commit updates azure_devops_v1 to
support both forms of AD config.

Does this introduce a breaking change

  • YES
  • NO

Testing

For reasons that are not entirely clear to me yet, CAF Terraform
has two ways of creating service principals:

aad_apps {
  # uses ./modules/azuread/applications
}

or,

azuread_applications {
  # uses ./modules/azuread/applications_v1
}

Also for reasons not yet clear to me, this repo provides two lzs for
configuring AZDO: caf_solution/add-ons/azure_devops and
caf_solution/add-ons/azure_devops_v1

The azure_devops module appears to use aad_apps, while azure_devops_v1
uses azuread_applications. This commit updates azure_devops_v1 to
support both forms of AD config.
@arnaudlh
Copy link
Member

arnaudlh commented Nov 4, 2021

hey @brk3 to clarify a bit on your doubts, azure_devops_v1 is the newest way to create AZDO objects. we kept to old azure_devops for backward compatibility but definitely will use v1 going forward as it allows much more granular way to create AZDO resources!

--> It's actually a good feedback and I will add a note in the ``azure_devops``` directory :)

Same applies for azuread_applications vs aad_apps

@arnaudlh arnaudlh added this to the 2111 milestone Nov 4, 2021
@arnaudlh arnaudlh changed the base branch from master to patch.5.4.4 November 4, 2021 04:02
Copy link
Member

@arnaudlh arnaudlh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arnaudlh arnaudlh added the enhancement New feature or request label Nov 10, 2021
@arnaudlh arnaudlh merged commit d74ae4c into Azure:patch.5.4.4 Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants