Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused var from add-ons/aad-pod-identity #274

Merged
merged 1 commit into from
Dec 7, 2021
Merged

Remove unused var from add-ons/aad-pod-identity #274

merged 1 commit into from
Dec 7, 2021

Conversation

brk3
Copy link
Contributor

@brk3 brk3 commented Nov 12, 2021 •
edited

aks_cluster_vnet_key isn't used anywhere in this addon, but there's no
default so terraform will make you supply one. Remove it.

Issue-id

PR Checklist

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • I ran lint checks locally prior to submission.
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Description

Does this introduce a breaking change

  • YES
  • NO

Testing

@brk3
Remove unused var from add-ons/aad-pod-identity
dc5ae42 
aks_cluster_vnet_key isn't used anywhere in this addon, but there's no
default so terraform will make you supply one. Remove it.
hieumoscow
hieumoscow approved these changes Dec 7, 2021
View reviewed changes
Copy link
Contributor

@hieumoscow hieumoscow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @brk3

@LaurentLesle LaurentLesle changed the base branch from master to 2112.int December 7, 2021 07:51
@LaurentLesle LaurentLesle merged commit 22dfb46 into Azure:2112.int Dec 7, 2021
@arnaudlh arnaudlh added the enhancement New feature or request label Dec 8, 2021
@arnaudlh arnaudlh added this to the 2112 milestone Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hieumoscow hieumoscow hieumoscow approved these changes

Assignees

@brk3 brk3

Labels
enhancement New feature or request
Projects
None yet
Milestone
2112
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@brk3 @hieumoscow @LaurentLesle @arnaudlh