Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add module for configuring SecretClass for CSI #280

Merged
merged 1 commit into from
Dec 8, 2021
Merged

Add module for configuring SecretClass for CSI #280

merged 1 commit into from
Dec 8, 2021

Conversation

brk3
Copy link
Contributor

@brk3 brk3 commented Nov 19, 2021 •
edited

This copies the pattern used in add-ons/aad-pod-identity to create and
apply a SecretProviderClass in AKS.

This is required to sync and mount secrets from KeyVault into pods using
the secrets-store-csi-driver-provider-azure AKS addon.

PR Checklist

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • I ran lint checks locally prior to submission.
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Description

Does this introduce a breaking change

  • YES
  • NO

Testing

@brk3 brk3 marked this pull request as draft November 19, 2021 10:07
@brk3 brk3 marked this pull request as ready for review November 19, 2021 10:57
@brk3
Add module for configuring SecretClass for CSI
29109d0 
This copies the pattern used in add-ons/aad-pod-identity to create and
apply a SecretProviderClass in AKS.

This is required to sync and mount secrets from KeyVault into pods using
the secrets-store-csi-driver-provider-azure AKS addon.
@LaurentLesle LaurentLesle added the enhancement New feature or request label Dec 7, 2021
hieumoscow
hieumoscow approved these changes Dec 7, 2021
View reviewed changes
Copy link
Contributor

@hieumoscow hieumoscow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contribution.
I have been looking into an example folder to include the tfvars for the addons.
Is this something you can create for this addon? @brk3

@LaurentLesle LaurentLesle changed the base branch from master to 2112.int December 8, 2021 05:52
@LaurentLesle LaurentLesle merged commit 4bd83a3 into Azure:2112.int Dec 8, 2021
@arnaudlh arnaudlh added this to the 2112 milestone Dec 8, 2021
@brk3
Copy link
Contributor Author

brk3 commented Dec 8, 2021

@hieumoscow sure no problem, I'll submit something in the next day or two 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaurentLesle LaurentLesle LaurentLesle approved these changes

@hieumoscow hieumoscow hieumoscow approved these changes

Assignees

@brk3 brk3

Labels
enhancement New feature or request
Projects
None yet
Milestone
2112
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@brk3 @LaurentLesle @hieumoscow @arnaudlh