Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update template and ignite #339

Merged
merged 5 commits into from
Mar 28, 2022
Merged

Update template and ignite #339

merged 5 commits into from
Mar 28, 2022

Conversation

LaurentLesle
Copy link
Contributor

Issue-id

PR Checklist

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • I ran lint checks locally prior to submission.
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Description

Does this introduce a breaking change

  • YES
  • NO

Testing

@arnaudlh arnaudlh removed the 5.6.0 label Mar 28, 2022
arnaudlh
arnaudlh approved these changes Mar 28, 2022
View reviewed changes
Copy link
Member

@arnaudlh arnaudlh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arnaudlh arnaudlh merged commit a638374 into main Mar 28, 2022
@arnaudlh arnaudlh deleted the patch.templates branch March 28, 2022 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnaudlh arnaudlh arnaudlh approved these changes

Assignees

@LaurentLesle LaurentLesle

Labels
5.5.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LaurentLesle @arnaudlh